fix: Mark WindowExec as incompatible [WIP]
#2736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2736 +/- ##
============================================
+ Coverage 56.12% 58.63% +2.50%
- Complexity 976 1460 +484
============================================
Files 119 162 +43
Lines 11743 13919 +2176
Branches 2251 2367 +116
============================================
+ Hits 6591 8161 +1570
- Misses 4012 4564 +552
- Partials 1140 1194 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
andygrove
changed the title
andygrove
commented
Nov 8, 2025
Comment on lines
+116
to
+117
| // https://github.com/apache/datafusion-comet/issues/2737 | ||
| // case _: WindowExec => true |
andygrove
changed the title
andygrove
changed the title
andygrove
changed the title
andygrove
changed the title
andygrove
changed the title
WindowExec as incompatible
andygrove
changed the title
WindowExec as incompatibleWindowExec as incompatible [WIP]
Member
Author
|
will create new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Need to merge #2741 first
Rationale for this change
Once #2741 is merged, we can implement
getSupportLevelforWindowExecand remove the hard-coded fix that previously disabled this operator.What changes are included in this PR?
WindowExectoopSerdeMapwindowExprToProtofromQueryPlanSerdetoCometWindowCometSinkclassWindowExecas as sink to work around org.apache.comet.CometNativeException: assertion failed: !self.format.is_null() #2737 (I do not understand what the root cause was though)How are these changes tested?